Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo update, fix bulid failure with ffmpeg 6.1, close #41 #42

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

linyinfeng
Copy link
Contributor

#41

@linyinfeng
Copy link
Contributor Author

linyinfeng commented Jan 17, 2024

CI tests failed https://github.com/LuckyTurtleDev/mstickereditor/actions/runs/7553156702/job/20563757581?pr=42. Seems cargo update raises new issues.
I'm going to convert this pull request to a draft.

@linyinfeng linyinfeng marked this pull request as draft January 17, 2024 09:05
@LuckyTurtleDev
Copy link
Owner

I was not able to reproduce the error local. So if have push the changes to an branch at this project and it works there. Apparently the pr do not have access to the projects secret, with cause the test to fail, because of missing bot token.

@LuckyTurtleDev LuckyTurtleDev marked this pull request as ready for review January 17, 2024 09:47
@LuckyTurtleDev LuckyTurtleDev merged commit 860fac9 into LuckyTurtleDev:main Jan 17, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants