Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for internal Valuer and Scanner values #15

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

thenixan
Copy link
Contributor

@thenixan thenixan commented Jan 6, 2024

I've used your library to wrap uuid.UUID type and unfortunately it seemed not to be working with types that have their own Scanner and Valuer implementation, so I've made a quick fix for that

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8b16952) 100.00% compared to head (cc43d63) 95.58%.

Files Patch % Lines
gonull.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #15      +/-   ##
===========================================
- Coverage   100.00%   95.58%   -4.42%     
===========================================
  Files            1        1              
  Lines           59       68       +9     
===========================================
+ Hits            59       65       +6     
- Misses           0        2       +2     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LukaGiorgadze
Copy link
Owner

LukaGiorgadze commented Jan 7, 2024

Hey @thenixan thank you for your contribution!
Good point, going to merge PR. However, one negative test case are missing and tests dropped by -4.42%, but I'll update it before the release.

Thanks!

@LukaGiorgadze LukaGiorgadze merged commit 20ecaea into LukaGiorgadze:main Jan 7, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants