-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added plex.tv/api/users #82
Conversation
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughIn this update, a new development dependency is added, and a novel API endpoint has been introduced. The endpoint, defined in a new YAML file, facilitates the retrieval of connected Plex users. Additionally, the primary API specification is amended to include this endpoint, and the testing utility has been refined to process XML responses by introducing a new parameter and helper function. These changes collectively adjust the configuration, endpoint definitions, and response validation logic. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant Server as API Server
participant Plex as Plex API
Client->>Server: GET /users (with Plex token)
Server->>Plex: Forward request to Plex API
Plex-->>Server: XML response with MediaContainer data
Server-->>Client: Return XML response with user list
sequenceDiagram
participant TestCaller as Test Script
participant Validator as validateResponseSpec
TestCaller->>Validator: Call validateResponseSpec(..., responseType="xml")
Validator->>Validator: Check if responseType is "xml"
Validator->>Validator: Convert XML to JSON via xml2json
Validator->>Validator: Flatten attributes using flattenAttributes
Validator-->>TestCaller: Return validated JSON data
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
added https://plex.tv/api/users
Summary by CodeRabbit
This release introduces a new API endpoint that enables retrieval of connected users with library access using an authentication token. The API documentation has been updated to accurately describe the new user data endpoint, providing clearer guidance for integration. These enhancements significantly simplify user management and improve overall API usability.