process_pending_orders bug fix #471
Conversation
|
My review is in progress 📖 - I will have feedback for you in a few minutes! |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I have reviewed your code and found 1 potential issue. To discuss my individual comments that I have added, tag me in replies using @korbit-ai.
Please react with a 👍 to my comments that you find helpful and a 👎 to those you find unhelpful - this will help me learn and improve as we collaborate.
| if process_pending_orders and hasattr(self.broker, "process_pending_orders"): | ||
| self.broker.process_pending_orders(strategy=self) |
There was a problem hiding this comment.
Using hasattr to check if self.broker has a process_pending_orders method can lead to unpredictable code and violates the 'tell, don't ask' principle. Consider defining a common interface or abstract base class for brokers that includes a process_pending_orders method. For brokers that don't need to process pending orders, you can implement this method as a no-op. This will make the code more predictable and maintainable.
No description provided.