polygon max retry bug fix #482
Conversation
|
My review is in progress 📖 - I will have feedback for you in a few minutes! |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I have reviewed your code and found 2 potential issues. To discuss my individual comments that I have added, tag me in replies using @korbit-ai.
Please react with a 👍 to my comments that you find helpful and a 👎 to those you find unhelpful - this will help me learn and improve as we collaborate.
| @@ -548,10 +552,11 @@ def _get(self, *args, **kwargs): | |||
| try: | |||
| return super()._get(*args, **kwargs) | |||
|
|
|||
| except MaxRetryError: | |||
| except MaxRetryError as e: | |||
There was a problem hiding this comment.
In the exception handling block for MaxRetryError, the variable name 'e' is not descriptive. Consider renaming it to 'max_retry_error' to provide more context about what it represents.
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| setuptools.setup( | |||
| name="lumibot", | |||
| version="3.5.10", | |||
| version="3.5.11", | |||
There was a problem hiding this comment.
I noticed that you've updated the version of the software package in the setup.py file, but this change is not reflected in the README.md file. It's important to keep the README.md file up-to-date with the latest version of the software package. Could you please update the README.md file to reflect this change?
No description provided.