Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs improvements #486

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Docs improvements #486

merged 2 commits into from
Jul 7, 2024

Conversation

grzesir
Copy link
Contributor

@grzesir grzesir commented Jul 7, 2024

No description provided.

Copy link
Contributor

korbit-ai bot commented Jul 7, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

@grzesir grzesir merged commit 004dd84 into dev Jul 7, 2024
1 check passed
Copy link
Contributor

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and found 1 potential issue. To discuss my individual comments that I have added, tag me in replies using @korbit-ai.


Please react with a 👍 to my comments that you find helpful and a 👎 to those you find unhelpful - this will help me learn and improve as we collaborate.

@@ -23,7 +23,7 @@
copyright = "2021, Lumiwealth"
author = "Lumiwealth Inc."

html_title = "Lumibot: Algorithmic Trading and Backtesting Library Documentation"
html_title = "Lumibot Documentation"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

category Naming

The change in 'html_title' from 'Lumibot: Algorithmic Trading and Backtesting Library Documentation' to 'Lumibot Documentation' makes the title less descriptive. It's important to have a title that accurately represents the content of the documentation. Consider reverting it back or choosing a more descriptive title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant