Update D3D replay codegen for arrays of COM pointers #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 274267. |
|
CI gfxreconstruct build # 4990 running. |
|
CI gfxreconstruct build # 4990 passed. |
bradgrantham-lunarg
added
P2
Add support for arrays of COM pointers to the replay consumer code generator: - Handle output arrays of COM pointers, adding them to the object table. - Support variable length arrays of output COM pointers.
dgraves
force-pushed
the
support-com-out-array
branch
from
e121b5a
to
dc117c3
Compare
|
CI gfxreconstruct build queued with queue ID 292207. |
|
CI gfxreconstruct build # 5255 running. |
|
CI gfxreconstruct build # 5255 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add COM pointer array support to the replay consumer code generator:
For the generated replay override code, the
SetConsumerDatacall was also moved behind the sameIsNullconditional check performed forSetHandleLength, because the consumer data won't be set when there are no handles to associate it with. This was primarily done for the array of COM objects case, to skip initialization of a vector of objects, but also applies to the single COM object case.IDXGIDevice::CreateSurface is currently the only function that outputs an array of COM pointers, but this change was pulled from the D3D11 branch where there are multiple D3D11 cases