dump resources: remove calls to exit(1) #1852
Conversation
|
CI gfxreconstruct build queued with queue ID 291996. |
|
CI gfxreconstruct build # 5250 running. |
|
CI gfxreconstruct build # 5250 passed. |
| @@ -1879,7 +1879,6 @@ VkResult VulkanReplayDumpResourcesBase::QueueSubmit(const std::vector<VkSubmitIn | |||
| GFXRECON_LOG_ERROR("Dumping draw calls failed (%s). Terminating.", | |||
| util::ToString<VkResult>(res).c_str()) | |||
| Release(); | |||
| exit(1); | |||
There was a problem hiding this comment.
Removing these means that the message is no longer true. But the message probably means that execution can't continue. Doesn't this need to terminate somehow, either by abort or throw or some such?
There was a problem hiding this comment.
Actually, probably GFXRECON_LOG_FATAL, I think.
There was a problem hiding this comment.
Looking at framework/util/logging.h, it seems there is no real difference between GFXRECON_LOG_ERROR and GFXRECON_LOG_FATAL. Do we want FATAL to terminate every time?
|
Fixes #1761 |
davidlunarg
force-pushed
the
davidp_remove_dr_exits
branch
from
f92eaa5
to
b190353
Compare
|
CI gfxreconstruct build queued with queue ID 306822. |
|
CI gfxreconstruct build # 5354 running. |
|
CI gfxreconstruct build # 5354 passed. |
Removed calls to exit() when fatal error is encountered in dump resources and instead call the error handler specified by VulkanReplayConsumerBase::SetFatalErrorHandler()
davidlunarg
force-pushed
the
davidp_remove_dr_exits
branch
from
b190353
to
8e09fc3
Compare
|
CI gfxreconstruct build queued with queue ID 317066. |
|
CI gfxreconstruct build queued with queue ID 317071. |
|
CI gfxreconstruct build # 5516 running. |
|
CI gfxreconstruct build # 5516 failed. |
No description provided.