Relax VulkanStateWriter's IsMemoryReadable() criteria #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 297891. |
|
CI gfxreconstruct build # 5321 running. |
|
CI gfxreconstruct build # 5321 passed. |
bradgrantham-lunarg
requested review from
antonio-lunarg
and removed request for
antonio-lunarg
|
This change slashed the WriteState() time by 50% on the s22. Unfortunately it has the complete opposite effect on every other platform I tested it. Leaving this in limbo in case there's a way to predict whether this can benefit or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.