Fix changing colors #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gepbird
force-pushed
the
fix-changing-colors
branch
from
c8417fd to
639cb85
Compare
|
I resolved the merge conflicts, feel free to take a look at this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, comments
and keywordsare changing colors when you load to file:darkplus-pr.mp4
This PR makes comments always green without italic (just like in vscode)
and treats builtin functions as functions so they are yellow.Unfortunately variables that are used as functions (like
hlin the video) are still changing colors. I assume neovim thinks it's a function because it has a(next to it so it gives the yellow highlight, then treesitter says it's just a variable and changes it back to light blue. I believe if lua_ls recognized it being a function it wouldn't change colors and stay yellow.Edit: removed "fix" for functions as it has been already implemented at d04d43d#diff-f6396e3ad2299402e37c1ffe426fc126f7c6bfc3ef40b49eed8ed657447a1442L127.