Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKIL-462 #709

Merged
merged 32 commits into from
Sep 28, 2024
Merged

SKIL-462 #709

merged 32 commits into from
Sep 28, 2024

Conversation

jcallison1
Copy link
Contributor

TODOs Completed:

  • Set up GitHub Actions to automatically build the backend, lint the frontend, and run Jest tests every time a PR is submitted or a change is pushed to master.
  • Pytests are not being run as they seem to be currently broken.
  • I had to add a hack to get the all of the Jest tests to pass, you can see the rationale for this hack in a comment at the top of FrontEndReact/jest-ci-setup.js. If anyone has an alternative to this hack, then I'd love to hear it.

@jcallison1
Initial attempt at adding automated testing
dca9b25
@jcallison1
Start using docker for backend test thjing
972c5c7
@jcallison1
Fix target format
59994a6
@jcallison1
Make sure that bake is actually required
b34a0d7
@jcallison1
Test no bake again
e761f9d
@jcallison1
Enable npm tests
8d97618
@jcallison1
Test if the backend can be reached
c9b1de6
@jcallison1
Attempt 2
1e6ed67
@jcallison1
Atempt 3
abff584
@jcallison1
Try tests with env var
61a2986
@jcallison1
Switch to just docker compose build
acd65aa
@jcallison1
Switch to node.js 20
20a165c
@jcallison1
Add eslint and disable jest tests for now
3c7604e
@jcallison1
Remove npm cache because there's no package-lock
e2a6489
@jcallison1
Merge branch 'SKIL-468' into SKIL-471
45a7e12
@jcallison1
Try to re-add npm cache
e4e19d1
@jcallison1
Trigger CI again to test cache
d5cd5e8
@jcallison1
Only run CI on PR
e3b5f6f
@jcallison1
Try to fix tests by decreasing workers
9eb865f
@jcallison1
For some reason jest couldn't find any tests?
745e758
@jcallison1
Fix jest args
195bf9a
@jcallison1
Try to fix timeout issues
89d616b
@jcallison1
Add cache for jest cache
99a14e2
@jcallison1
Whitespace change to test CI again
98c8226
@jcallison1
Switch to cache v4
4dc1db7
@jcallison1
Test jest cache again
3cf0193
@jcallison1
Test cache again 2
13b247f
@jcallison1
Clean up CI and add comments
2df0471
@jcallison1
Minor changes
9290776
@jcallison1
Remove unspecific cache restore keys
4cc91ef
aparriaran
aparriaran approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@aparriaran aparriaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sah0017 LGTM!

@jcallison1 jcallison1 requested review from Adham-Alammuri and removed request for ebanderson3 September 28, 2024 20:13
Adham-Alammuri
Adham-Alammuri approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@Adham-Alammuri Adham-Alammuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aparriaran
Copy link
Collaborator

@sah0017 I am going to merge this PR!

@aparriaran aparriaran merged commit bf889fe into master Sep 28, 2024
1 check passed
@aparriaran aparriaran deleted the SKIL-462 branch September 28, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparriaran aparriaran aparriaran approved these changes

@Adham-Alammuri Adham-Alammuri Adham-Alammuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcallison1 @aparriaran @Adham-Alammuri