Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKIL-441 #710

Closed
wants to merge 12 commits into from
Closed

SKIL-441 #710

wants to merge 12 commits into from

Conversation

jcallison1
Copy link
Contributor

@jcallison1 jcallison1 commented Sep 29, 2024 •
edited
Loading

TODOs Completed:

  • Added a new docker compose file that allows running the Jest tests, Pytests, and ESLint using docker.
  • The Jest tests in the new docker compose file have the setTimeout hack enabled because docker slows things down just enough sometimes to cause some tests to fail.
  • Renamed the setTimeout hack file to make it not specific to the CI.
  • Upped the setTimeout hack timeout from 10 seconds to 60 seconds.
  • Added instructions to the README on how to use this new compose file.
  • Made frontend in regular docker compose file depend on backend.

@aparriaran aparriaran closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adham-Alammuri Adham-Alammuri Awaiting requested review from Adham-Alammuri

@aparriaran aparriaran Awaiting requested review from aparriaran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcallison1 @aparriaran