-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SKIL-440 #714
SKIL-440 #714
Conversation
hmnur3636
commented
Oct 1, 2024
- Reporting Page now fits on the screen
- Fixed bug in Ratings that made it disappear when showRatings is false and added a place holder icon when it is false.
- Improvements now has a placeholder image when showSuggestions is false. And fixed ShowSuggestions since it was accidentally written out of the code when tabs stopped being used in Improvements/Characteristics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have some merge conflicts in Reporting/ViewAssessmentStatus/ViewAssessmentStatus.js
that need to be taken care of before this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sah0017 LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sah0017 LGTM
@sah0017 I am going to merge this PR! |