Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKIL-440 #714

Merged
merged 5 commits into from
Oct 3, 2024
Merged

SKIL-440 #714

merged 5 commits into from
Oct 3, 2024

Conversation

hmnur3636
Copy link
Contributor

  • Reporting Page now fits on the screen
  • Fixed bug in Ratings that made it disappear when showRatings is false and added a place holder icon when it is false.
  • Improvements now has a placeholder image when showSuggestions is false. And fixed ShowSuggestions since it was accidentally written out of the code when tabs stopped being used in Improvements/Characteristics.

@hmnur3636 hmnur3636 requested a review from aparriaran October 1, 2024 17:32
@hmnur3636 hmnur3636 requested a review from jcallison1 October 2, 2024 21:49
Copy link
Contributor

@jcallison1 jcallison1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have some merge conflicts in Reporting/ViewAssessmentStatus/ViewAssessmentStatus.js that need to be taken care of before this can be merged.

Copy link
Collaborator

@aparriaran aparriaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sah0017 LGTM!

Copy link
Contributor

@jcallison1 jcallison1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sah0017 LGTM

@aparriaran
Copy link
Collaborator

@sah0017 I am going to merge this PR!

@aparriaran aparriaran merged commit 0796080 into master Oct 3, 2024
1 check passed
@aparriaran aparriaran deleted the SKIL-440 branch October 3, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants