Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKIL-491 #768

Merged
merged 19 commits into from
Nov 19, 2024
Merged

SKIL-491 #768

merged 19 commits into from
Nov 19, 2024

Conversation

aldoeve
Copy link
Contributor

@aldoeve aldoeve commented Nov 15, 2024

TODOs Completed:
-this should cover SKIL-489, SKIL-488, SKIL-516. This should allow for future formats on exporting csv files and will fix the current major issues.

aldo and others added 18 commits November 5, 2024 17:53
…and the new export function is on the way. Most of the export function is still under work as client specs are considered and intergrated
…They also output differently to make things easier to deal with. The old function should still be used to reslove the current query problems. The next step is integrating it for the teams
…ort function. Work on the lag time and ocs,sfi querey is still in progress.
…s now properly hooked up. There needs to be some testing and refactoring first before this branch can commit
…delimiter is tab since that seems unlikly to be used and is common for other services to auto pick up on.
…rts. I need to refactor and document what has been written. Perhpas the template method pattern is adventageous here.
@aparriaran aparriaran changed the title Skil 491 SKIL491 Nov 15, 2024
@aparriaran aparriaran changed the title SKIL491 SKIL-491 Nov 15, 2024
Copy link
Collaborator

@aparriaran aparriaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sah0017 LGTM

Copy link
Contributor

@ebanderson3 ebanderson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sah0017 LGTM!

@aparriaran
Copy link
Collaborator

@sah0017 I am going to merge this PR

@aparriaran aparriaran merged commit debfb18 into master Nov 19, 2024
1 check passed
@aparriaran aparriaran deleted the SKIL-491 branch November 19, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants