-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SKIL-491 #768
Merged
Merged
SKIL-491 #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atetoriges is worked on by andre
…and the new export function is on the way. Most of the export function is still under work as client specs are considered and intergrated
…They also output differently to make things easier to deal with. The old function should still be used to reslove the current query problems. The next step is integrating it for the teams
…ort function. Work on the lag time and ocs,sfi querey is still in progress.
…s now properly hooked up. There needs to be some testing and refactoring first before this branch can commit
… what is going wrong with lag
…delimiter is tab since that seems unlikly to be used and is common for other services to auto pick up on.
…the ratings data is being worked on
…rts. I need to refactor and document what has been written. Perhpas the template method pattern is adventageous here.
… for similar exports.
aparriaran
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sah0017 LGTM
ebanderson3
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sah0017 LGTM!
@sah0017 I am going to merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs Completed:
-this should cover SKIL-489, SKIL-488, SKIL-516. This should allow for future formats on exporting csv files and will fix the current major issues.