Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKIL-487 #769

Merged
merged 88 commits into from
Nov 19, 2024
Merged

SKIL-487 #769

merged 88 commits into from
Nov 19, 2024

Conversation

Mr615-TN
Copy link
Collaborator

@Mr615-TN Mr615-TN commented Nov 18, 2024

TODOs Completed:
Admin can delete teams based on whether the team has an associated assessment task with it or not

…tuff and also need to fully add some more functionality
…am, but currently in process of reworking to code to make it better
@aparriaran aparriaran changed the title Skil 487 SKIL-487 Nov 18, 2024
Copy link
Collaborator

@aparriaran aparriaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sah0017 LGTM

@@ -72,6 +72,8 @@ def get_assessment_tasks_by_team_id(team_id):
(AssessmentTask.due_date >= Team.date_created and AssessmentTask.due_date <= Team.active_until)
)
).all()
print(queried_results, flush=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a print statement here?

Copy link
Contributor

@zaramalik03 zaramalik03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aparriaran
Copy link
Collaborator

@sah0017 I am going to merge this PR

@aparriaran aparriaran merged commit c5b2f6e into master Nov 19, 2024
1 check failed
@aparriaran aparriaran deleted the SKIL-487 branch November 19, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants