Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skil group #799

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Skil group #799

wants to merge 27 commits into from

Conversation

malloc-nbytes
Copy link
Collaborator

This PR covers the following tickets:

  1. SKIL-509
  2. SKIL-527
  3. SKIL-526
  4. SKIL-503
  5. SKIL-511

Note for SKIL-515: It seems that the latest updates to Master has broken the feature to view the CAT. Therefore I have omitted my work for it until that issue is resolved.

@malloc-nbytes malloc-nbytes requested a review from sah0017 December 9, 2024 17:29
@sah0017
Copy link
Contributor

sah0017 commented Dec 10, 2024

@malloc-nbytes I got some linter warnings when I ran your code:
[eslint]
src/View/Admin/View/ViewAssessmentTask/ViewAssessmentTasks.js
Line 8:65: 'genericResourcePOST' is defined but never used no-unused-vars

src/View/Student/View/AssessmentTask/StudentViewAssessmentTask.js
Line 78:15: 'filteredCATs' is assigned a value but never used no-unused-vars

src/View/Student/View/AssessmentTask/ViewAssessmentTasks.js
Line 76:13: 'completedAssessmentTasks' is assigned a value but never used no-unused-vars
Line 147:29: 'at' is assigned a value but never used no-unused-vars

src/View/Student/View/CompletedAssessmentTask/StudentCompletedAssessmentTasks.js
Line 57:15: 'filteredATs' is assigned a value but never used no-unused-vars

src/View/Student/View/CompletedAssessmentTask/ViewCompletedAssessmentTasks.js
Line 12:13: 'navbar' is assigned a value but never used no-unused-vars

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

WARNING in [eslint]
src/View/Admin/View/ViewAssessmentTask/ViewAssessmentTasks.js
Line 8:65: 'genericResourcePOST' is defined but never used no-unused-vars

src/View/Student/View/AssessmentTask/StudentViewAssessmentTask.js
Line 78:15: 'filteredCATs' is assigned a value but never used no-unused-vars

src/View/Student/View/AssessmentTask/ViewAssessmentTasks.js
Line 76:13: 'completedAssessmentTasks' is assigned a value but never used no-unused-vars
Line 147:29: 'at' is assigned a value but never used no-unused-vars

src/View/Student/View/CompletedAssessmentTask/StudentCompletedAssessmentTasks.js
Line 57:15: 'filteredATs' is assigned a value but never used no-unused-vars

src/View/Student/View/CompletedAssessmentTask/ViewCompletedAssessmentTasks.js
Line 12:13: 'navbar' is assigned a value but never used no-unused-vars

webpack compiled with 1 warning

It also failed the CI due to these warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants