Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multi binary native communication over WebSockets #417

Merged
merged 43 commits into from
Mar 31, 2023
Merged

Enable multi binary native communication over WebSockets #417

merged 43 commits into from
Mar 31, 2023

Conversation

nicolas-rabault
Copy link
Member

@nicolas-rabault nicolas-rabault commented Jan 12, 2023 •
edited by JeromeGalan
Loading

Changes

Please choose the relevant options:

  • New feature (non-breaking change which adds functionality)

WARNING: Do not edit the checklist below.

Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault self-assigned this Jan 12, 2023
@JeromeGalan JeromeGalan force-pushed the feat/native2 branch 2 times, most recently from c322754 to dc6b52b Compare January 12, 2023 16:32
@nicolas-rabault nicolas-rabault changed the base branch from rc_2.9.0 to main February 6, 2023 14:23
@nicolas-rabault nicolas-rabault changed the base branch from main to rc_2.9.0 February 6, 2023 14:23
@nicolas-rabault nicolas-rabault force-pushed the feat/native2 branch 3 times, most recently from d8b85ee to 54145c0 Compare February 14, 2023 13:45
@nicolas-rabault nicolas-rabault force-pushed the feat/native2 branch 2 times, most recently from 20996b8 to bc3b3ab Compare February 15, 2023 23:06
@nicolas-rabault nicolas-rabault linked an issue Feb 17, 2023 that may be closed by this pull request
[NEW FEATURE] Native step 2 : Multiple nodes running #291
Closed
@nicolas-rabault nicolas-rabault added this to the 2.9.0 milestone Mar 28, 2023
nicolas-rabault and others added 14 commits March 28, 2023 21:52
@JeromeGalan JeromeGalan linked an issue Mar 29, 2023 that may be closed by this pull request
[NEW FEATURE] Native support #292
Closed
JeromeGalan
JeromeGalan approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@JeromeGalan JeromeGalan merged commit 03016f4 into rc_2.9.0 Mar 31, 2023
@JeromeGalan JeromeGalan deleted the feat/native2 branch March 31, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeGalan JeromeGalan JeromeGalan approved these changes

Assignees

@nicolas-rabault nicolas-rabault

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

[NEW FEATURE] Native support [NEW FEATURE] Native step 2 : Multiple nodes running
4 participants
@nicolas-rabault @JeromeGalan @K0rdan @BiliouriV