Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

La/hydration error #109

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

La/hydration error #109

wants to merge 15 commits into from

Conversation

lazarusA
Copy link
Collaborator

@lazarusA lazarusA commented Apr 3, 2024

if the solution proposed here works, then this should fix #81

@asinghvi17
Copy link
Collaborator

I don't think this worked - I pushed a v0.0.16+docs1 tag and it built to the correct dir (see 5c320b5). Unfortunately the stable site is still not working.

To replicate, just push a new tag to the repo of the name v0.0.16+docs$i.

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 3, 2024

do you see any hydration error ? anywhere? (is the same link, to the latest release? ) Also, I see that the diff in link you posted is kinda big.

@asinghvi17
Copy link
Collaborator

asinghvi17 commented Apr 3, 2024

Screenshot 2024-04-03 at 1 28 19 PM

This shows a hydration error as well...:(

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 3, 2024

yeah... here some related vuejs/vitepress#3586 , but weird for us... why the ones that work, are actually working ?

@asinghvi17
Copy link
Collaborator

I think the only common factor is the trustees in the sidebar...maybe removing those would help?

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

DimensionalData.jl doesn't have them.

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

more info, this is the corresponding warning:

The resource <URL> was preloaded using link preload but not used within a few seconds from the window’s load event. Please make sure it has an appropriate as value and it is preloaded intentionally.
definitely, is the re-direct load.

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

@asinghvi17 ok, could you test this one again, please? Also, could you please describe step by step how does this tagging works?

DP> git tag v0.0.16+docs$i # what's the $i for?
DP> git push v0.0.16+docs$I

is it like that? (from the current branch, la/hydration_error)

@asinghvi17
Copy link
Collaborator

I mean the $i in the Julia iteration sense, so docs1, docs2, docs3 - sorry for the confusion!

Yep that approach is pretty much correct except the push.

git tag v0.0.16+docs2
git push --tag

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

ok... thanks... I will try... after fixing the exclusion... as it is, the syntax is wrong 😄 .

@asinghvi17
Copy link
Collaborator

I added DEBUG=true to the build CI just so we have more info, btw

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

yeah... it doesn't work. :( bad regex. I will leave it now. RIP 😢 .

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

Screenshot 2024-04-04 at 14 42 40 All of them have this error in common. The `favicon` path is not available for any site. Maybe not the issue, again. But another one 😞 .

@asinghvi17
Copy link
Collaborator

Maybe for the favicon we have to modify the replacer, to push the correct path?

@asinghvi17
Copy link
Collaborator

asinghvi17 commented Apr 4, 2024

Screenshot 2024-04-04 at 8 55 12 AM

Here's the error I'm getting now - I also enabled debug logging. You can go straight to stable for this.

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

Screenshot 2024-04-04 at 14 59 21

for me it looks like this. This is the first error, in the debugger mode.

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

and... that file, framework.... is really long for the packages failing.

For the ones working is really small:
Screenshot 2024-04-04 at 15 10 16

my guess, is that we were using different versions of packages in the json config file.

Edit: nevermind... is not static... now I see the same pattern either way.

@lazarusA
Copy link
Collaborator Author

should we just use this solution? Not sure where exactly incorporate this into the current workflow.

https://github.com/LuxDL/Lux.jl/blob/daf571ac359fe602ba9ef773c444298c66bb1378/.github/workflows/DeployDocs.yml#L36-L39 @asinghvi17 ?

@asinghvi17
Copy link
Collaborator

asinghvi17 commented May 17, 2024

Huh, it looks like that fixes the Lux issue as well! Yeah if we can rewrite this in Julia that would be awesome to include. Then we only need the version selector to be "feature-complete" :D

Edit: nevermind, that would only work at the doc deployment stage! Would have to add that as a hook to deploydocs, which would be difficult in general usage (but would work for the DV docs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symlinkined paths like stable and latest dont work on some repos but not others
2 participants