-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
La/hydration error #109
base: master
Are you sure you want to change the base?
La/hydration error #109
Conversation
I don't think this worked - I pushed a v0.0.16+docs1 tag and it built to the correct dir (see 5c320b5). Unfortunately the stable site is still not working. To replicate, just push a new tag to the repo of the name |
do you see any |
yeah... here some related vuejs/vitepress#3586 , but weird for us... why the ones that work, are actually working ? |
I think the only common factor is the trustees in the sidebar...maybe removing those would help? |
DimensionalData.jl doesn't have them. |
more info, this is the corresponding warning:
|
@asinghvi17 ok, could you test this one again, please? Also, could you please describe step by step how does this tagging works?
is it like that? (from the current branch, la/hydration_error) |
I mean the Yep that approach is pretty much correct except the push. git tag v0.0.16+docs2
git push --tag |
ok... thanks... I will try... after fixing the exclusion... as it is, the syntax is wrong 😄 . |
I added DEBUG=true to the build CI just so we have more info, btw |
yeah... it doesn't work. :( bad regex. I will leave it now. RIP 😢 . |
Maybe for the favicon we have to modify the replacer, to push the correct path? |
should we just use this solution? Not sure where exactly incorporate this into the current workflow. https://github.com/LuxDL/Lux.jl/blob/daf571ac359fe602ba9ef773c444298c66bb1378/.github/workflows/DeployDocs.yml#L36-L39 @asinghvi17 ? |
Huh, it looks like that fixes the Lux issue as well! Edit: nevermind, that would only work at the doc deployment stage! Would have to add that as a hook to |
if the solution proposed here works, then this should fix #81