-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the code for debug mode #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark Results
Benchmark suite | Current: 3d97254 | Previous: ca23485 | Ratio |
---|---|---|---|
Dense(2 => 2)/cpu/reverse/ReverseDiff (compiled)/(2, 128) |
3624.25 ns |
3668.125 ns |
0.99 |
Dense(2 => 2)/cpu/reverse/Zygote/(2, 128) |
7004.428571428572 ns |
7213.5 ns |
0.97 |
Dense(2 => 2)/cpu/reverse/Tracker/(2, 128) |
20768 ns |
20719 ns |
1.00 |
Dense(2 => 2)/cpu/reverse/ReverseDiff/(2, 128) |
9734 ns |
9491.8 ns |
1.03 |
Dense(2 => 2)/cpu/reverse/Flux/(2, 128) |
8703.5 ns |
8806 ns |
0.99 |
Dense(2 => 2)/cpu/reverse/SimpleChains/(2, 128) |
4542.25 ns |
4459.5 ns |
1.02 |
Dense(2 => 2)/cpu/reverse/Enzyme/(2, 128) |
1173.5248226950355 ns |
1168.8964285714287 ns |
1.00 |
Dense(2 => 2)/cpu/forward/NamedTuple/(2, 128) |
1127.832258064516 ns |
1114.5125 ns |
1.01 |
Dense(2 => 2)/cpu/forward/ComponentArray/(2, 128) |
1203.3923076923077 ns |
1189.8149606299212 ns |
1.01 |
Dense(2 => 2)/cpu/forward/Flux/(2, 128) |
1793.6785714285713 ns |
1789.4912280701753 ns |
1.00 |
Dense(2 => 2)/cpu/forward/SimpleChains/(2, 128) |
179.47249647390692 ns |
180.64739069111425 ns |
0.99 |
Dense(20 => 20)/cpu/reverse/ReverseDiff (compiled)/(20, 128) |
17252 ns |
17293 ns |
1.00 |
Dense(20 => 20)/cpu/reverse/Zygote/(20, 128) |
17012 ns |
17072 ns |
1.00 |
Dense(20 => 20)/cpu/reverse/Tracker/(20, 128) |
36628 ns |
37099 ns |
0.99 |
Dense(20 => 20)/cpu/reverse/ReverseDiff/(20, 128) |
28092 ns |
28267.5 ns |
0.99 |
Dense(20 => 20)/cpu/reverse/Flux/(20, 128) |
19346 ns |
19726 ns |
0.98 |
Dense(20 => 20)/cpu/reverse/SimpleChains/(20, 128) |
16941 ns |
17041 ns |
0.99 |
Dense(20 => 20)/cpu/reverse/Enzyme/(20, 128) |
4355.285714285715 ns |
4381 ns |
0.99 |
Dense(20 => 20)/cpu/forward/NamedTuple/(20, 128) |
3861 ns |
3919.75 ns |
0.99 |
Dense(20 => 20)/cpu/forward/ComponentArray/(20, 128) |
3937.25 ns |
3968.75 ns |
0.99 |
Dense(20 => 20)/cpu/forward/Flux/(20, 128) |
4904.714285714285 ns |
4980.714285714285 ns |
0.98 |
Dense(20 => 20)/cpu/forward/SimpleChains/(20, 128) |
1659 ns |
1651.1 ns |
1.00 |
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 3, 128) |
39687290 ns |
38465553 ns |
1.03 |
Conv((3, 3), 3 => 3)/cpu/reverse/Zygote/(64, 64, 3, 128) |
57781588 ns |
57659332.5 ns |
1.00 |
Conv((3, 3), 3 => 3)/cpu/reverse/Tracker/(64, 64, 3, 128) |
78142261 ns |
75839555 ns |
1.03 |
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff/(64, 64, 3, 128) |
85321213 ns |
88548014.5 ns |
0.96 |
Conv((3, 3), 3 => 3)/cpu/reverse/Flux/(64, 64, 3, 128) |
74343334 ns |
72339313 ns |
1.03 |
Conv((3, 3), 3 => 3)/cpu/reverse/SimpleChains/(64, 64, 3, 128) |
11923944.5 ns |
11961965 ns |
1.00 |
Conv((3, 3), 3 => 3)/cpu/reverse/Enzyme/(64, 64, 3, 128) |
17652879 ns |
17669780 ns |
1.00 |
Conv((3, 3), 3 => 3)/cpu/forward/NamedTuple/(64, 64, 3, 128) |
6976303 ns |
6995246 ns |
1.00 |
Conv((3, 3), 3 => 3)/cpu/forward/ComponentArray/(64, 64, 3, 128) |
6944894 ns |
6962483.5 ns |
1.00 |
Conv((3, 3), 3 => 3)/cpu/forward/Flux/(64, 64, 3, 128) |
12048031.5 ns |
9966425 ns |
1.21 |
Conv((3, 3), 3 => 3)/cpu/forward/SimpleChains/(64, 64, 3, 128) |
6381777 ns |
6382304 ns |
1.00 |
vgg16/cpu/reverse/Zygote/(32, 32, 3, 16) |
697335731 ns |
697509537 ns |
1.00 |
vgg16/cpu/reverse/Zygote/(32, 32, 3, 64) |
2837518037 ns |
2845090431 ns |
1.00 |
vgg16/cpu/reverse/Zygote/(32, 32, 3, 2) |
159251557.5 ns |
145155933 ns |
1.10 |
vgg16/cpu/reverse/Tracker/(32, 32, 3, 16) |
863742077 ns |
758659457 ns |
1.14 |
vgg16/cpu/reverse/Tracker/(32, 32, 3, 64) |
2995927262 ns |
2623555098 ns |
1.14 |
vgg16/cpu/reverse/Tracker/(32, 32, 3, 2) |
222325578 ns |
200798179 ns |
1.11 |
vgg16/cpu/reverse/Flux/(32, 32, 3, 16) |
667496190.5 ns |
699711870.5 ns |
0.95 |
vgg16/cpu/reverse/Flux/(32, 32, 3, 64) |
2886170523 ns |
2744166224 ns |
1.05 |
vgg16/cpu/reverse/Flux/(32, 32, 3, 2) |
141042575 ns |
126860588 ns |
1.11 |
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 16) |
172594630.5 ns |
172959021 ns |
1.00 |
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 64) |
645750910 ns |
641219872 ns |
1.01 |
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 2) |
34129319 ns |
34131572 ns |
1.00 |
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 16) |
163515643 ns |
163961135.5 ns |
1.00 |
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 64) |
635674352 ns |
640443712 ns |
0.99 |
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 2) |
29600098 ns |
44002993 ns |
0.67 |
vgg16/cpu/forward/Flux/(32, 32, 3, 16) |
201607207 ns |
187456866.5 ns |
1.08 |
vgg16/cpu/forward/Flux/(32, 32, 3, 64) |
809233740.5 ns |
713774150 ns |
1.13 |
vgg16/cpu/forward/Flux/(32, 32, 3, 2) |
35724944 ns |
35709005 ns |
1.00 |
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 64, 128) |
1247773994.5 ns |
1018397448 ns |
1.23 |
Conv((3, 3), 64 => 64)/cpu/reverse/Zygote/(64, 64, 64, 128) |
1858337277.5 ns |
1855972375.5 ns |
1.00 |
Conv((3, 3), 64 => 64)/cpu/reverse/Tracker/(64, 64, 64, 128) |
2077807586 ns |
2022754963.5 ns |
1.03 |
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff/(64, 64, 64, 128) |
2394583493 ns |
2335834774.5 ns |
1.03 |
Conv((3, 3), 64 => 64)/cpu/reverse/Flux/(64, 64, 64, 128) |
2003551065 ns |
1986661818 ns |
1.01 |
Conv((3, 3), 64 => 64)/cpu/reverse/Enzyme/(64, 64, 64, 128) |
553560408.5 ns |
553501401 ns |
1.00 |
Conv((3, 3), 64 => 64)/cpu/forward/NamedTuple/(64, 64, 64, 128) |
318788470.5 ns |
315992941 ns |
1.01 |
Conv((3, 3), 64 => 64)/cpu/forward/ComponentArray/(64, 64, 64, 128) |
317268529.5 ns |
317023478 ns |
1.00 |
Conv((3, 3), 64 => 64)/cpu/forward/Flux/(64, 64, 64, 128) |
464839354 ns |
347738717 ns |
1.34 |
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 1, 128) |
11663192 ns |
11815270 ns |
0.99 |
Conv((3, 3), 1 => 1)/cpu/reverse/Zygote/(64, 64, 1, 128) |
17920583 ns |
17834636 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/reverse/Tracker/(64, 64, 1, 128) |
19089790 ns |
19192128 ns |
0.99 |
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff/(64, 64, 1, 128) |
23802622.5 ns |
23877834 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/reverse/Flux/(64, 64, 1, 128) |
17913926 ns |
17885797.5 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/reverse/SimpleChains/(64, 64, 1, 128) |
1152671 ns |
1159948 ns |
0.99 |
Conv((3, 3), 1 => 1)/cpu/reverse/Enzyme/(64, 64, 1, 128) |
5823150 ns |
5756297 ns |
1.01 |
Conv((3, 3), 1 => 1)/cpu/forward/NamedTuple/(64, 64, 1, 128) |
2037295 ns |
2045846 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/forward/ComponentArray/(64, 64, 1, 128) |
2019653 ns |
2025049 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/forward/Flux/(64, 64, 1, 128) |
2063183.5 ns |
2063594 ns |
1.00 |
Conv((3, 3), 1 => 1)/cpu/forward/SimpleChains/(64, 64, 1, 128) |
199611 ns |
196457 ns |
1.02 |
Dense(200 => 200)/cpu/reverse/ReverseDiff (compiled)/(200, 128) |
290139 ns |
293588 ns |
0.99 |
Dense(200 => 200)/cpu/reverse/Zygote/(200, 128) |
264381.5 ns |
266698 ns |
0.99 |
Dense(200 => 200)/cpu/reverse/Tracker/(200, 128) |
358992 ns |
372466.5 ns |
0.96 |
Dense(200 => 200)/cpu/reverse/ReverseDiff/(200, 128) |
403510 ns |
411890 ns |
0.98 |
Dense(200 => 200)/cpu/reverse/Flux/(200, 128) |
272897 ns |
275955 ns |
0.99 |
Dense(200 => 200)/cpu/reverse/SimpleChains/(200, 128) |
404872 ns |
409134 ns |
0.99 |
Dense(200 => 200)/cpu/reverse/Enzyme/(200, 128) |
83274 ns |
83476 ns |
1.00 |
Dense(200 => 200)/cpu/forward/NamedTuple/(200, 128) |
81011 ns |
81713 ns |
0.99 |
Dense(200 => 200)/cpu/forward/ComponentArray/(200, 128) |
81191 ns |
81983 ns |
0.99 |
Dense(200 => 200)/cpu/forward/Flux/(200, 128) |
86371 ns |
87163 ns |
0.99 |
Dense(200 => 200)/cpu/forward/SimpleChains/(200, 128) |
104404 ns |
104885 ns |
1.00 |
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 16, 128) |
205720365 ns |
194040756 ns |
1.06 |
Conv((3, 3), 16 => 16)/cpu/reverse/Zygote/(64, 64, 16, 128) |
322689838 ns |
322670128 ns |
1.00 |
Conv((3, 3), 16 => 16)/cpu/reverse/Tracker/(64, 64, 16, 128) |
435009535 ns |
389461276 ns |
1.12 |
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff/(64, 64, 16, 128) |
476213467 ns |
444888078.5 ns |
1.07 |
Conv((3, 3), 16 => 16)/cpu/reverse/Flux/(64, 64, 16, 128) |
404980223 ns |
370487396.5 ns |
1.09 |
Conv((3, 3), 16 => 16)/cpu/reverse/SimpleChains/(64, 64, 16, 128) |
321831696.5 ns |
322523445.5 ns |
1.00 |
Conv((3, 3), 16 => 16)/cpu/reverse/Enzyme/(64, 64, 16, 128) |
100238912.5 ns |
100716976.5 ns |
1.00 |
Conv((3, 3), 16 => 16)/cpu/forward/NamedTuple/(64, 64, 16, 128) |
43520434 ns |
43623492 ns |
1.00 |
Conv((3, 3), 16 => 16)/cpu/forward/ComponentArray/(64, 64, 16, 128) |
43315772 ns |
43429429 ns |
1.00 |
Conv((3, 3), 16 => 16)/cpu/forward/Flux/(64, 64, 16, 128) |
61318536 ns |
49450779 ns |
1.24 |
Conv((3, 3), 16 => 16)/cpu/forward/SimpleChains/(64, 64, 16, 128) |
28327135 ns |
29173706 ns |
0.97 |
Dense(2000 => 2000)/cpu/reverse/ReverseDiff (compiled)/(2000, 128) |
18723058 ns |
18903962 ns |
0.99 |
Dense(2000 => 2000)/cpu/reverse/Zygote/(2000, 128) |
19438993.5 ns |
19514972 ns |
1.00 |
Dense(2000 => 2000)/cpu/reverse/Tracker/(2000, 128) |
23170760 ns |
23289075 ns |
0.99 |
Dense(2000 => 2000)/cpu/reverse/ReverseDiff/(2000, 128) |
23976568 ns |
24083888 ns |
1.00 |
Dense(2000 => 2000)/cpu/reverse/Flux/(2000, 128) |
19526666 ns |
19573855.5 ns |
1.00 |
Dense(2000 => 2000)/cpu/reverse/Enzyme/(2000, 128) |
6489180 ns |
6522431 ns |
0.99 |
Dense(2000 => 2000)/cpu/forward/NamedTuple/(2000, 128) |
6482842 ns |
6516955 ns |
0.99 |
Dense(2000 => 2000)/cpu/forward/ComponentArray/(2000, 128) |
6480311 ns |
6494018.5 ns |
1.00 |
Dense(2000 => 2000)/cpu/forward/Flux/(2000, 128) |
6474961 ns |
6498216.5 ns |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.