Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Commit

Permalink
test: mark truncated normal on Metal as unbroken
Browse files Browse the repository at this point in the history
  • Loading branch information
avik-pal committed Oct 8, 2024
1 parent aef7442 commit d060a84
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ConcreteStructs = "0.2.3"
GPUArraysCore = "0.1.6"
GPUArrays = "10.2"
LinearAlgebra = "1.10"
Metal = "1.1.0"
Metal = "1.3.0"
Random = "1.10"
SpecialFunctions = "2.4"
Statistics = "1.10"
Expand Down
8 changes: 3 additions & 5 deletions test/initializers_tests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ end
init === randn32) &&
continue

if (backend == "oneapi" || backend == "metal") && init === truncated_normal
if backend == "oneapi" && init === truncated_normal
@test_broken size(init(rng, 3)) == (3,) # `erfinv` not implemented
continue
end
Expand Down Expand Up @@ -229,9 +229,7 @@ end

init === truncated_normal && !(T <: Real) && continue

if (backend == "oneapi" || backend == "metal") &&
init === truncated_normal &&
T == Float32
if backend == "oneapi" && init === truncated_normal && T == Float32
@test_broken init(rng, T, 3) isa AbstractArray{T, 1} # `erfinv` not implemented
continue
end
Expand Down Expand Up @@ -261,7 +259,7 @@ end
@testset "Closure: $init" for init in [
kaiming_uniform, kaiming_normal, glorot_uniform,
glorot_normal, truncated_normal, identity_init]
if (backend == "oneapi" || backend == "metal") && init === truncated_normal
if backend == "oneapi" && init === truncated_normal
@test_broken size(init(rng, 3)) == (3,) # `erfinv` not implemented
continue
end
Expand Down

0 comments on commit d060a84

Please sign in to comment.