-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 6 #2504
Conversation
Is there already a time horizon for completion :) ? |
I wish. :') I have a PR here to create a small blog: waiting for reviews. :) |
The site looks nice. The main menu item "Docs" has no content yet. If I understand correctly, this project will also replace the current project website? |
No, just an update/refresher of the LycheeOrg website, nothing much there. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yeah I need to redo a lot of the translations. :( |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Probably not available in the Docker version either |
I would move it to the Config section for Owner and Title |
use Lychee instead of current Hide Lychee version number |
What can the setting? |
There is a number which unit has this?
The 2 points would probably belong together |
There are some settings in the video area that could be merged.
|
Does not speak for itself the title Sensitive Albums would perhaps bring more clarity |
This comment was marked as resolved.
This comment was marked as resolved.
Does this make any sense at all as the images are already compressed as jpeg. The size will probably not really improve significantly
Probably not usable in Docker either |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Quite a few things to improve... On one hand, I can see why this is a bit overwhelming, but on the other hand I would like this to be transparent for users, so that they don't feel that they have to look through each tab one by one... (that is why I added the menu on the right to jump directly to a section or another. That way users can just scroll down to discover the settings, one page, nothing hidden, but also have quick access to each part. One thing that I am missing as capabilities in this page, is the ability to reorder (as a dev) the settings and the categories. I also do agree that footer can probably be split, moved in some other section. What I am unsure is whether this refactoring should happen before or after release of v6. I do not want to put too much pressure on my dear @d7415 :) |
The Setting Page optimization can of course also come with 6.1. I think this is primarily about a sensibly organized settings dialogue. Probably a small pull request from my point of view. If you don't want a tab then we could pursue an approach with the right menu. And integrate the important points at the beginning and then list the detailed settings further down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm clicking approve because at this point I can't remember many of the comments, but I don't think any were critical. Most are about comments.
Co-authored-by: Martin Stone <[email protected]>
Co-authored-by: Martin Stone <[email protected]>
Co-authored-by: Martin Stone <[email protected]>
Then we are now ready to start the merge here? 🤩 |
Proposal We are excited to announce the release of Lychee version 6! This new version brings a major upgrade with a completely reworked frontend built on Vue.js. By leveraging the power and flexibility of Vue, we've enhanced the overall user experience, making the interface more responsive, modern, and easier to navigate. |
Someone made quite a few comments on this PR, so that someone will have to wait for that stack of 17 PR to be collapse into this one. 🤣 Then we will be able to merge. 😄 So once @d7415 reviewed 8, 9, 10, 11, 13, 14, 15, 16, 17, I will apply the merges and then Version 6 will be live.
I actually quite like the image, the text feels still a bit too ChatGPT~ish :) |
That is a weird image. But I am on board with an anthropomorphised lychee. |
* Stacked 2: Fix sharing - add icon to indicate read access (#2564) * Stacked 3: fix play icon not showing on images (#2579) * Stacked 4: Fix error message : details on upload (#2566) * Stacked 5: Fix visibility updated wrong message (#2567) * Stacked 6: Fix styling of left menu per @d7415 request :D (#2568) * Stacked 7: Clear create album name on creation/move (#2569) * Stacked 8: Fix visibility not updating when traversing albums (#2570) * Stacked 9: Remove redundant auth check query (#2572) * Stacked 10: Add footer also in albums and album (#2571) * Stacked 11: Fix VueJs not usable in sub folders. (#2573) * Staked 12: Fix qr code not working (#2576) * Stacked 13: Statistics per album (#2577) * Stacked 14: Allow to chose the photo layout per album (#2575) * Stacked 15: Show owner instead of just Shared albums (#2574) * Stacked 16: Composer update + fixing phpstan / Ts checker (#2580) * Stacked 17: Various fixes. (#2581) --------- Co-authored-by: Martin Stone <[email protected]>
Fixes #106
Closes #126
Fixes #226 (SE)
Closes #520 (SE)
Fixes #987
Fixes #1420
Closes #1641 (SE)
Fixes #1987
Fixes #2082
Fixes #2086
Fixes #2168
Fixes #2194
Fixes #2361
Fixes #2495