Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable lazy loading for pictures past number 10 in an album #2633

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Enable lazy loading for pictures past number 10 in an album #2633

merged 1 commit into from
Oct 31, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Oct 30, 2024

No description provided.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Oct 30, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (6fc3e35) to head (f0f1c53).
Report is 4 commits behind head on master.

Additional details and impacted files

@ildyria
Copy link
Member Author

ildyria commented Oct 30, 2024

I don't know why snq is complaining.

d7415
d7415 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ildyria ildyria merged commit 03b7d6d into master Oct 31, 2024
48 of 49 checks passed
@ildyria ildyria deleted the lazy branch October 31, 2024 01:33
aSouchereau pushed a commit that referenced this pull request Nov 9, 2024
@ildyria @aSouchereau
enable lazy loading for pictures past 10 in an album (#2633)
e944e9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415