Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instruction for using tags #2811

Merged
merged 2 commits into from
Dec 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions resources/js/components/forms/photo/PhotoTagDialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@
<Dialog v-model:visible="visible" pt:root:class="border-none" modal :dismissable-mask="true">
<template #container="{ closeCallback }">
<div class="p-9 text-center text-muted-color">
<p class="mb-5 text-sm/4">
<p class="text-sm/8">
{{ question }}
<br />
<span class="text-muted-color-emphasis">
<i class="text-warning-600 pi pi-exclamation-triangle mr-2" />Press Enter to confirm each tag.
</span>
</p>
<div class="my-3 first:mt-0 last:mb-0">
<AutoComplete
Expand Down Expand Up @@ -40,7 +44,6 @@ import { sprintf } from "sprintf-js";
import { useToast } from "primevue/usetoast";
import Button from "primevue/button";
import Dialog from "primevue/dialog";
import { trans } from "laravel-vue-i18n";
import Checkbox from "primevue/checkbox";
import AutoComplete from "primevue/autocomplete";

Expand All @@ -60,9 +63,9 @@ const toast = useToast();

const question = computed(() => {
if (props.photo) {
return trans("lychee.PHOTO_NEW_TAGS");
return sprintf("Enter your tags for this photo.");
}
return sprintf(trans("lychee.PHOTOS_NEW_TAGS"), props.photoIds?.length);
return sprintf("Enter your tags for all %d selected photos. Existing tags will be overwritten.", props.photoIds?.length);
});

const shallOverride = ref(false);
Expand Down
Loading