Exit with error for unsupported S3 backend #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiancross
force-pushed
the
add-tool-error
branch
from
6d6c7de to
a75d043
Compare
The `lychee:generate_thumbs` command does not support the S3 backend. This commit outputs an error message and exits the tool when the command is invoked with such a backend, avoiding incorrect behaviour such as writing images to the filesystem.
kiancross
force-pushed
the
add-tool-error
branch
from
a75d043 to
7aafbd5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files |
ildyria
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lychee:generate_thumbscommand does not support the S3 backend. This commit outputs an error message and exits the tool when the command is invoked with such a backend, avoiding incorrect behaviour such as writing images to the filesystem.