Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset localization (sorry) + improved clarity of language setup #2877

Merged
merged 49 commits into from
Jan 10, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 4, 2025

Requires #2877 , once merged fix localization before merging this one.

@ildyria ildyria changed the title Reset localization + improved setup 🚧 Reset localization + improved setup Jan 4, 2025
@ildyria ildyria changed the title 🚧 Reset localization + improved setup 🚧 Reset localization + improved setup Jan 4, 2025
@ildyria ildyria marked this pull request as ready for review January 5, 2025 20:52
@ildyria ildyria requested a review from d7415 January 5, 2025 20:52
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 5, 2025
@ildyria ildyria added this to the 6.3 milestone Jan 5, 2025
@ildyria ildyria changed the title 🚧 Reset localization + improved setup Reset localization (sorry) + improved clarity of setup Jan 5, 2025
@ildyria ildyria changed the title Reset localization (sorry) + improved clarity of setup Reset localization (sorry) + improved clarity of language setup Jan 5, 2025
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.05%. Comparing base (99b463b) to head (9adb8a3).
Report is 7 commits behind head on master.

Additional details and impacted files

Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess language changes will also need copying to other languages, but that should be straightforward :)

lang/en/dialogs.php Outdated Show resolved Hide resolved
lang/en/dialogs.php Outdated Show resolved Hide resolved
lang/en/dialogs.php Outdated Show resolved Hide resolved
lang/en/dialogs.php Outdated Show resolved Hide resolved
lang/en/left-menu.php Outdated Show resolved Hide resolved
lang/en/profile.php Outdated Show resolved Hide resolved
lang/en/settings.php Outdated Show resolved Hide resolved
lang/en/settings.php Outdated Show resolved Hide resolved
resources/js/components/settings/EasySettings.vue Outdated Show resolved Hide resolved
'description' => 'Description',
'photo_ordering' => 'Order photos by',
'children_ordering' => 'Order albums by',
'asc/desc' => 'asc/desc',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ is ok here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, tested working :)

@ildyria ildyria merged commit 8e13ee2 into master Jan 10, 2025
52 checks passed
@ildyria ildyria deleted the localization branch January 10, 2025 00:59
ildyria added a commit to sancsin/Lychee that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants