Stk 3 - Add favourite store + handle heart click #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files🚀 New features to boost your workflow:
|
ildyria
force-pushed
the
favourite-client-side
branch
from
8cff504 to
1ac4375
Compare
ildyria
changed the title
ildyria
added
the
Review: easy
ildyria
changed the title
tinohager
reviewed
Mar 10, 2025
| @@ -118,8 +119,17 @@ const emits = defineEmits<{ | |||
| help: []; | |||
| }>(); | |||
|
|
|||
| // 'UPLOAD_PHOTO' => 'Upload Photo', | |||
There was a problem hiding this comment.
Do you need the commentary here?
tinohager
reviewed
Mar 10, 2025
| import Button from "primevue/button"; | ||
| import Toolbar from "primevue/toolbar"; | ||
| import { ref } from "vue"; | ||
| import { computed } from "vue"; |
There was a problem hiding this comment.
ref, computed, onMounted can set in the same import
tinohager
approved these changes
Mar 10, 2025
ildyria
force-pushed
the
no-more-photo-page
branch
from
293bbba to
abaacc6
Compare
ildyria
force-pushed
the
favourite-client-side
branch
from
7ad3073 to
24f33b1
Compare
ildyria
force-pushed
the
no-more-photo-page
branch
from
abaacc6 to
2459c9c
Compare
ildyria
force-pushed
the
favourite-client-side
branch
from
24f33b1 to
a151bd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
photoClickis renamedphotoSelect<a>with@clickhandler.The reason is that the heart favourite click would bubble up and open the link no matter what.