Ignore tags with null or empty values (#50)

LycheeOrg · Jul 22, 2022 · 2bd2d34 · 2bd2d34
1 parent ef77c37
commit 2bd2d34
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 3 deletions.
diff --git a/lib/PHPExif/Hydrator/Mutator.php b/lib/PHPExif/Hydrator/Mutator.php
@@ -33,10 +33,12 @@ class Mutator implements HydratorInterface
     public function hydrate($object, array $data) : void
     {
         foreach ($data as $property => $value) {
-            $mutator = $this->determineMutator($property);
+            if ($value !== null && $value !== '') {
+                $mutator = $this->determineMutator($property);
 
-            if (method_exists($object, $mutator)) {
-                $object->$mutator($value); // @phpstan-ignore-line, PhpStan does not like variadic calls
+                if (method_exists($object, $mutator)) {
+                    $object->$mutator($value); // @phpstan-ignore-line, PhpStan does not like variadic calls
+                }
             }
         }
     }

diff --git a/tests/PHPExif/Hydrator/MutatorTest.php b/tests/PHPExif/Hydrator/MutatorTest.php
@@ -61,10 +61,41 @@ public function testHydrateCallsMutatorsOnObject()
         $hydrator = new \PHPExif\Hydrator\Mutator;
         $hydrator->hydrate($mock, $input);
     }
+
+    /**
+     * @group hydrator
+     * @covers \PHPExif\Hydrator\Mutator::hydrate
+     */
+    public function testHydrateCallsEmptyValues()
+    {
+        // input data
+        $input = array(
+            'foo' => null,
+            'bar' => '',
+        );
+
+        // create mock
+        $mock = $this->getMockBuilder('TestClass')
+            ->setMethods(array('setFoo', 'setBar'))
+            ->getMock();
+
+        $mock->expects($this->exactly(0))
+            ->method('setFoo');
+        $mock->expects($this->exactly(0))
+            ->method('setBar');
+
+        // do the test
+        $hydrator = new \PHPExif\Hydrator\Mutator;
+        $hydrator->hydrate($mock, $input);
+    }
 }
 
 class TestClass
 {
+    public function setFoo()
+    {
+    }
+
     public function setBar()
     {
     }