Require CI success on stable #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know when/if you get this working, so I can merge it. |
|
There's an open issue relative to the CI error on nightly: rustwasm/wasm-bindgen#2009. |
|
Oh I didn't check the error message. Funnily enough I'm aware of that bug because I had to work around it recently in a completely unrelated situation. |
This commit removes the `allow_failure` config for stable Rust. According to the comment it is no longer needed since the release of Rust 1.32.
demurgos
force-pushed
the
ci-allow-failure
branch
from
bb3033c to
31e3f53
Compare
|
Now that the fixed nightly is available, I triggered CI again and it passed. |
eddyb
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
allow_failureconfig for stable Rust. According to the comment it is no longer needed since the release of Rust 1.32.