Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load certificate at startup #9

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Load certificate at startup #9

merged 1 commit into from
Jan 7, 2024

Conversation

rosahaj
Copy link

@rosahaj rosahaj commented Jan 7, 2024

Fixes #7

I'm not familiar with golang, thus I'd appreciate it if this PR was reviewed before being merged.

Certificates are loaded after certificate generation and before the server starts. Incorrect certificate and private key files are thus detected before the first connection and files aren't reloaded on every connection.

Copy link
Owner

@LyleMi LyleMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LyleMi LyleMi marked this pull request as ready for review January 7, 2024 05:13
@LyleMi LyleMi merged commit 2587bfc into LyleMi:master Jan 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Load certificate and key at startup
2 participants