Directly read from S3 via s3fs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This performs marginally faster than performing downloads, and uses roughly the same amount of memory. |
|
Oops. I forgot about the unit test... |
|
@jjfrench, this is ready for review now. I sorted out a bit of a gnarly unit test issue where s3fs (actually aiohttp) and moto don't play nicely together without some assistance. |
|
@jjfrench, this is a pretty small PR. Any chance you can review it this week? |
jjfrench
reviewed
May 15, 2024
jjfrench
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54