-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune s3fs cache settings for optimal performance #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildintellect
approved these changes
Jun 28, 2024
wildintellect
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good for me, but you've got an error in the test due to a missing import for typing related to fsspec. Probably want to resolve that before merging.
Run make typecheck
+ [[ true == \t\r\u\e ]]
+ mypy src tests typings
src/gedi_subset/subset.py:23: error: Skipping analyzing "fsspec": module is installed, but missing library stubs or py.typed marker [import-untyped]
src/gedi_subset/subset.py:23: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 16 source files)
make: *** [Makefile:56: typecheck] Error 1
Error: Process completed with exit code 2.
@wildintellect, I fixed the build failure. Did you want to take another pass over the changes before I merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based upon benchmarking tests, I've set the default s3fs cache settings to one of the better performing combinations. There were a number of combinations that performed very similarly, so the choice was a bit of a toss up, as many of them provide roughly a 10% speed improvement (on average) over the speed of downloading files. The speedup is not particularly notable, but that's not surprising, given that the granule files are not cloud-optimized.
However, this sets us up for possible further improvements, even with the non-cloud-optimized files, if we discover a more efficient means of writing our subsetting logic that requires fewer s3 read requests.
Fixes #77
Fixes #69