Merge pull request #538 from MLecardonnel/feature/python_version

Feature/python version

.github/workflows/main.yml

@@ -8,7 +8,7 @@ jobs:
     strategy:
       max-parallel: 1
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     steps:
     - uses: actions/checkout@v3
     - name: Set up Python ${{ matrix.python-version }}

README.md

@@ -143,7 +143,7 @@ Shapash can use category-encoders object, sklearn ColumnTransformer or simply fe
 
 ## 🛠 Installation
 
-Shapash is intended to work with Python versions 3.8 to 3.11. Installation can be done with pip:
+Shapash is intended to work with Python versions 3.9 to 3.12. Installation can be done with pip:
 
 ```bash
 pip install shapash

docs/installation-instructions/index.rst

@@ -4,7 +4,7 @@ Installation instructions
 Installing
 ----------
 
-**Shapash** is intended to work with Python versions 3.8 to 3.11. Installation can be done with pip:
+**Shapash** is intended to work with Python versions 3.9 to 3.12. Installation can be done with pip:
 
 .. code:: bash
 

setup.py

@@ -66,7 +66,7 @@
 setup(
     name="shapash",
     version=version_d["__version__"],
-    python_requires=">3.7, <3.12",
+    python_requires=">3.8, <3.13",
     url="https://github.com/MAIF/shapash",
     author="Yann Golhen, Sebastien Bidault, Yann Lagre, Maxime Gendre",
     author_email="[email protected]",
@@ -75,10 +75,10 @@
     long_description_content_type="text/markdown",
     classifiers=[
         "Programming Language :: Python :: 3",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
+        "Programming Language :: Python :: 3.12",
         "License :: OSI Approved :: Apache Software License",
         "Operating System :: OS Independent",
     ],

tests/unit_tests/explainer/test_smart_explainer.py

@@ -1,6 +1,7 @@
 """
 Unit test for smart explainer
 """
+
 import os
 import sys
 import types
@@ -633,14 +634,14 @@ def test_load_1(self):
         temp, xpl = init_sme_to_pickle_test()
 
         current = Path(path.abspath(__file__)).parent.parent.parent
-        if str(sys.version)[0:3] == "3.8":
-            pkl_file = path.join(current, "data/xpl_to_load_38.pkl")
-        elif str(sys.version)[0:3] == "3.9":
+        if str(sys.version)[0:3] == "3.9":
             pkl_file = path.join(current, "data/xpl_to_load_39.pkl")
         elif str(sys.version)[0:4] == "3.10":
             pkl_file = path.join(current, "data/xpl_to_load_310.pkl")
         elif str(sys.version)[0:4] == "3.11":
             pkl_file = path.join(current, "data/xpl_to_load_311.pkl")
+        elif str(sys.version)[0:4] == "3.12":
+            pkl_file = path.join(current, "data/xpl_to_load_312.pkl")
         else:
             raise NotImplementedError
 

tests/unit_tests/utils/test_load_smartpredictor.py

@@ -1,6 +1,7 @@
 """
 Unit test smart predictor
 """
+
 import sys
 import unittest
 from os import path
@@ -29,12 +30,12 @@ def test_load_smartpredictor_1(self):
         current = Path(path.abspath(__file__)).parent.parent.parent
         if str(sys.version)[0:4] == "3.10":
             pkl_file = path.join(current, "data/predictor_to_load_310.pkl")
-        elif str(sys.version)[0:3] == "3.8":
-            pkl_file = path.join(current, "data/predictor_to_load_38.pkl")
         elif str(sys.version)[0:3] == "3.9":
             pkl_file = path.join(current, "data/predictor_to_load_39.pkl")
         elif str(sys.version)[0:4] == "3.11":
             pkl_file = path.join(current, "data/predictor_to_load_311.pkl")
+        elif str(sys.version)[0:4] == "3.12":
+            pkl_file = path.join(current, "data/predictor_to_load_312.pkl")
         else:
             raise NotImplementedError