Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #472 but still need some discussion #504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekamioka
Copy link

This PR removes columns with constant values that will generate NaNs values durante the correlation matrix calculation.

Therefore, I believe it is still required a discussion towards:

  • assess the impact of the columns removed in face of the report
  • assess the feasibility/need to inform/war the user about the removal
  • address the presence of columns containing constant values as a new report section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant