Skip to content

Commit

Permalink
fix: fix rust imports with native feature
Browse files Browse the repository at this point in the history
  • Loading branch information
Mcdostone committed Dec 15, 2024
1 parent d3d1378 commit 5454236
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/developer-experience.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Run try-it.sh
run: bash docs/try-it.sh
env:
YOZEFU_API_URL: http://localhost:8082/schemas/types
YOZEFU_API_URL: http://localhost:8081/schemas/types

wasm-rust:
runs-on: ubuntu-latest
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/semver-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ jobs:
- name: Make sure version is updated
if: ${{ steps.current.outputs.version == steps.next.outputs.version }}
run: |
echo "::warning title=Next version:: Last public version is '${{ steps.current.outputs.version }}' but version of this branch is '${{ steps.next.outputs.version }}'. Did you forget to update the version? More details at https://github.com/MAIF/yozefu/blob/main/docs/release.md"
echo "::warning title=Next version:: Last public version is '${{ steps.current.outputs.version }}' but version of this branch is '${{ steps.next.outputs.version }}'. Did you forget to update the version? More details at https://github.com/MAIF/yozefu/blob/main/docs/release/README.md"
printf 'This pull request is not ready because the crate version is equals to the latest git tag version `' > report.md
printf "${{ steps.next.outputs.version }}" >> report.md
printf '`. I think you forgot to bump the version. More details at https://github.com/MAIF/yozefu/blob/main/docs/release.md' >> report.md
printf '`. I think you forgot to bump the version. More details at https://github.com/MAIF/yozefu/blob/main/docs/release/README.md' >> report.md
gh pr comment ${{ github.event.number }} --body-file ./report.md
exit 1
env:
Expand All @@ -88,7 +88,7 @@ jobs:
- name: Run cargo semver-checks
if: ${{ steps.next.outputs.version != '' && steps.semver.outputs.release != '' }}
id: check
run: cargo semver-checks --color never --package yozefu-lib --package yozefu-app --package yozefu-types --baseline-rev "${{ steps.current.outputs.version }}" --release-type "${{ steps.semver.outputs.release }}" >> "$GITHUB_OUTPUT"
run: cargo semver-checks --color never --package yozefu-lib --package yozefu-app --package yozefu-wasm-types --package yozefu-command --baseline-rev "${{ steps.current.outputs.version }}" --release-type "${{ steps.semver.outputs.release }}" >> "$GITHUB_OUTPUT"
- name: Publish semver-checks report
if: ${{ steps.check.outcome != 'success' && steps.check.outcome != 'skipped' }}
run: |
Expand Down
3 changes: 2 additions & 1 deletion crates/lib/src/kafka/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ pub mod topic;
pub use schema_registry_client::SchemaRegistryClient;
#[cfg(feature = "native")]
mod avro;
#[cfg(feature = "native")]
pub use schema_registry_client::SchemaResponse;

mod data_type;
mod kafka_record;
Expand All @@ -18,4 +20,3 @@ pub use data_type::Comparable;
pub use data_type::DataType;
pub use kafka_record::KafkaRecord;
pub use schema::SchemaId;
pub use schema_registry_client::SchemaResponse;
15 changes: 13 additions & 2 deletions docs/release/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,19 @@ This document explains the release process of the tool. Most of the steps are au

1. Ensure you are on a release branch.
2. Install `cargo-release`: `cargo install cargo-release`
3. Thanks to conventional commits and `cargo-semver-checks`, you can determine the next version to release.
4. Bump the version: `cargo release "<major | minor | patch>" --no-publish --no-confirm --execute --no-tag`
3. Thanks to conventional commits and `cargo-semver-checks`, you can determine the next version to release:

```bash
cargo semver-checks --color never \
--package yozefu-lib \
--package yozefu-app \
--package yozefu-command \
--package yozefu-wasm-types \
--baseline-rev "vX.Y.Z" \
--release-type "<major | minor | patch>"
```

4. Bump the version based on the previous step: `cargo release "<major | minor | patch>" --no-publish --no-confirm --execute --no-tag`
5. [Create the pull request](https://github.com/MAIF/yozefu/compare).
6. If all checks succeed, the pull request will be accepted by a reviewer.
7. When a new release is created, a github action workflow is triggered to update the changelog. The updated changelog will be available on a branch named `changelog/<version>`. A pull request is automatically created with that branch, which must be approved to be merged into `main`.

0 comments on commit 5454236

Please sign in to comment.