Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support skipped lines #6

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Updates to support skipped lines #6

merged 2 commits into from
Jun 13, 2024

Conversation

rgtj2
Copy link
Contributor

@rgtj2 rgtj2 commented Jun 6, 2024

Support skipping lines using nil values

Support skipping lines using `nil` values
@rgtj2 rgtj2 requested review from jhixson and deepankar-j June 6, 2024 21:49
@deepankar-j
Copy link
Contributor

Looks good, Ron! A couple requests:

  • Could you please update the documentation to explain the skipped line behavior?
  • Could you please bump the lib version?

Add to the documentation for `new!` and `line_numbers` to explain how `nil` values are treated as `skipped` lines
Copy link
Collaborator

@jhixson jhixson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rgtj2 rgtj2 merged commit 7085da6 into main Jun 13, 2024
3 checks passed
@rgtj2 rgtj2 deleted the feature/skip-lines branch June 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants