[Feat] Replace dependency on Apple with returned version from f-api #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HotaruBlaze
force-pushed
the
nso-version-fix
branch
from
496b3fc
to
977b884
Compare
HotaruBlaze
force-pushed
the
nso-version-fix
branch
from
977b884
to
49eb9bb
Compare
|
Gotta love fixing a commit typo and it triggering a mass rebuild, I really should split up GH Actions more lol |
HotaruBlaze
changed the title
|
Nice, thanks @HotaruBlaze! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the old system of scraping the version of NSO from the apple store, and instead use the version that our f-api generation is currently using.
This should in theory prevent ANY more issues with tokens being invalid when nintendo pushes an update before F-API can update.
https://api.imink.app/config
{"nso_version":"2.10.0"}I also moved a couple of helper funcs from app.py to api/init.py.