Skip to content

Conversation

Copilot
Copy link

@Copilot Copilot AI commented May 20, 2025

This PR implements a configuration system for ShowScript with initial options for debug logging and timings control.

Features Added

Configuration System

  • New Configuration class to manage loading, saving, and accessing configuration values
  • Default config.yml file with initial configuration options
  • Configuration values persist across server restarts

Configuration Commands

  • /show config reload - Reloads configuration from disk
  • /show config get <key> - Gets the value of a configuration option
  • /show config set <key> <value> - Sets the value of a configuration option

Initial Configuration Options

  • debug-logging - Controls whether debug messages are logged to console (default: true)
  • enable-timings - Controls whether Aikar's timings are enabled (default: true)
    • Useful for 1.20+ servers to avoid console spam since timings are deprecated in newer versions

Modified Components

  • Updated Main.java to initialize and use the configuration
  • Modified DebugLogger to use the configuration value
  • Updated timing-related code to respect the timings configuration
  • Preserved existing toggledebug command for backward compatibility

Usage Examples

/show config get debug-logging
/show config set enable-timings false
/show config reload

Fixes #7.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • plugins-artifacts.gradle.org
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -XX:MaxMetaspaceSize=256m -XX:&#43;HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.0-bin/ca5e32bp14vu59qr306oxotwh/gradle-8.0/lib/gradle-launcher-8.0.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.0 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Copilot Copilot AI changed the title [WIP] Configuration Options Add Configuration System with Debug and Timings Options May 20, 2025
@Copilot Copilot AI requested a review from RyanHecht May 20, 2025 00:17
Copilot finished work on behalf of RyanHecht May 20, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration Options
3 participants