Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links for User Guide #394

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Oct 21, 2024

Fixed broken links for User Guide

Close: #393


📚 Documentation preview 📚: https://mdanalysisuserguide--394.org.readthedocs.build/en/394/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your link updates. Sorry for the long delay in giving you feedback.

Please see my comments inline. Thank you!

doc/source/examples/analysis/alignment_and_rms/README.rst Outdated Show resolved Hide resolved
doc/source/releases.md Outdated Show resolved Hide resolved
doc/source/contributing.rst Outdated Show resolved Hide resolved
@orbeckst orbeckst self-assigned this Dec 18, 2024
@mhmohona mhmohona requested a review from orbeckst December 19, 2024 00:58
@orbeckst
Copy link
Member

Please fix the formatting that makes the pre-commit check fail https://github.com/MDAnalysis/UserGuide/actions/runs/12404131142/job/34628800686?pr=394

@orbeckst
Copy link
Member

You can install pre-commit yourself and let it fix these things, see https://userguide.mdanalysis.org/stable/contributing_docs.html#using-pre-commit-hooks

@mhmohona
Copy link
Contributor Author

Hello @orbeckst, thank you for your help. I have fixed the precommit issue. Can you please have a look at it again?

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good, thank you for promptly addressing my requested changes.

Thanks a lot for your contribution (and your patience!!).

@orbeckst orbeckst merged commit 50cbb8a into MDAnalysis:develop Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Dead Links in MDAnalysis User Guide Documentation
2 participants