Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken encore test #1179

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Fix broken encore test #1179

merged 1 commit into from
Jan 19, 2017

Conversation

kain88-de
Copy link
Member

@kain88-de kain88-de commented Jan 19, 2017 •
edited
Loading

Fixes #1168

Changes made in this Pull Request:

  • cast values for PureRMSD to float64

PR Checklist

- [ ] Tests?
- [ ] Docs?
- [ ] CHANGELOG updated?

  • Issue raised/referenced?

@jbarnoud
Copy link
Contributor

Since you're at it: there is a typo few lines after your change on line 218. The line says:

elif fit_coords is not None and fit_coords is not None:

based on line 210, I am almost sure it should be:

elif fit_coords is not None and fit_masses is not None:

@richardjgowers
Copy link
Member

John's comment seems like a good issue, but I want my CI back, so I'm merging this

@richardjgowers richardjgowers merged commit 7032b27 into develop Jan 19, 2017
@kain88-de kain88-de deleted the floating-test-failure branch January 19, 2017 20:55
@kain88-de kain88-de mentioned this pull request Jan 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardjgowers richardjgowers richardjgowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kain88-de @jbarnoud @richardjgowers