Update PR template after relicensing #4860
Open
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4860 +/- ##
===========================================
- Coverage 93.65% 93.63% -0.03%
===========================================
Files 177 189 +12
Lines 21779 22845 +1066
Branches 3064 3064
===========================================
+ Hits 20398 21391 +993
- Misses 929 1002 +73
Partials 452 452 ☔ View full report in Codecov by Sentry. |
orbeckst
requested changes
Jan 6, 2025
| @@ -1,15 +1,12 @@ | |||
| Fixes # | |||
| Fixes #<!-- Insert issue number that this PR fixes just after #--> | |||
There was a problem hiding this comment.
Put on a separate line? I don't think that many people know that this is a comment and can either be removed or is ignored.
|
|
||
| Changes made in this Pull Request: | ||
| - | ||
| - <!-- Describe the changes that this PR makes. --> |
There was a problem hiding this comment.
I'd remove, the "Changes made in this Pull Request" is already pretty clear, isn't it?
|
|
||
|
|
||
| PR Checklist | ||
| ------------ | ||
| - [ ] Tests? | ||
| - [ ] Docs? | ||
| - [ ] Tests added? |
| - [ ] Tests? | ||
| - [ ] Docs? | ||
| - [ ] Tests added? | ||
| - [ ] Documentation updated? | ||
| - [ ] CHANGELOG updated? | ||
| - [ ] Issue raised/referenced? |
There was a problem hiding this comment.
For first time contributors:
Add your name to AUTHORS
Comment on lines
-14
to
-15
| ## Developers certificate of origin | ||
| - [ ] I certify that this contribution is covered by the LGPLv2.1+ license as defined in our [LICENSE](https://github.com/MDAnalysis/mdanalysis/blob/develop/LICENSE) and adheres to the [**Developer Certificate of Origin**](https://developercertificate.org/). |
There was a problem hiding this comment.
I agree with removing.
@IAlibay , your opinion is also important here – can you please weigh in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct me if I'm wrong, but now that relicensing is completed, can we remove the "Certificate of origin"?
📚 Documentation preview 📚: https://mdanalysis--4860.org.readthedocs.build/en/4860/