Skip to content

Commit

Permalink
[ci fpe] fpe check
Browse files Browse the repository at this point in the history 
ppisn was disabling the filling arrays with nans
  • Loading branch information
@rjfarmer
rjfarmer committed Jun 19, 2023
1 parent 6642f4d commit e64aefd
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion star/test_suite/ppisn/inlist_ppisn
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@

&controls

fill_arrays_with_nans = .false.
report_solver_progress = .false.
max_resid_jump_limit = 1d99

Expand Down

2 comments on commit e64aefd

@fxt44
Copy link
Member

@fxt44 fxt44 commented on e64aefd Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% setenv MESA_FPE_CHECKS_ON 1

TEST_COMPILE ../src/test_colors.f90
LOADER ../tester

FAILED

/Users/fxt/.mesa_test/work/colors/test
TEST FAILED -- compare test_output to tmp.txt

tmp.txt on an m1 shows

Program received signal SIGILL: Illegal instruction.

Backtrace for this error:
#0 0x100b66147
...

tmp.txt on an intel shows

Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.

Backtrace for this error:
#0 0x10a62cb7e
...

am i still doing something wrong with fpe checks?

@rjfarmer
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope you caught an actual fpe which got fixed in https://testhub.mesastar.org/main/commits/3fb7174 but is not yet on this branch

Please sign in to comment.