Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve option decodable conformance #6

Merged
merged 8 commits into from
May 9, 2023

Conversation

roanutil
Copy link
Member

@roanutil roanutil commented May 5, 2023

  • Add static functions of unwrap implementations on Option when unwrap is not required in the initializer
  • Add convenience initializers when Value conforms to RawRepresentable and when Value conforms to both RawRepresentable and CustomStringConvertible
  • Relax Option's conformance to Decodable to not require Value conform to CustomStringConvertible. Instead, throw error if unwrap implementation is not found in the Decoder's userInfo dictionary
  • Add conditional conformance to DecodableWithConfiguration to Option
  • Add test cases to OptionTests to catch regressions of behavior when Option.Value conforms to both RawRepresentable and CustomStringConvertible
  • Add default.profraw to gitignore
  • Add explicit token for codecov in macos-test workflow job
  • Update dependencies

roanutil added 8 commits May 5, 2023 14:00
…is not required in the initializer

feature/improve-option-decodable-conformance
…CustomStringConvertible> and when Value conforms to both RawRepresentable<CustomStringConvertible> and CustomStringConvertible

feature/improve-option-decodable-conformance
…to CustomStringConvertible. Instead, throw error if unwrap implementation is not found in the Decoder's userInfo dictionary.

feature/improve-option-decodable-conformance
feature/improve-option-decodable-conformance
…ption.Value conforms to both RawRepresentable<CustomStringConvertible> and CustomStringConvertible

feature/improve-option-decodable-conformance
feature/improve-option-decodable-conformance
feature/improve-option-decodable-conformance
feature/improve-option-decodable-conformance
@roanutil roanutil temporarily deployed to default May 5, 2023 19:12 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default May 5, 2023 19:12 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default May 5, 2023 19:12 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default May 5, 2023 19:12 — with GitHub Actions Inactive
@roanutil roanutil enabled auto-merge May 5, 2023 19:15
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #6 (f734f04) into main (88d8003) will decrease coverage by 4.39%.
The diff coverage is 45.26%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   86.48%   82.10%   -4.39%     
==========================================
  Files          16       16              
  Lines         873      961      +88     
==========================================
+ Hits          755      789      +34     
- Misses        118      172      +54     
Impacted Files Coverage Δ
Sources/ArgumentEncoding/Option.swift 38.70% <30.98%> (-6.35%) ⬇️
Tests/ArgumentEncodingTests/OptionTests.swift 90.90% <87.50%> (-9.10%) ⬇️

... and 3 files with indirect coverage changes

@roanutil roanutil merged commit 7cff84a into main May 9, 2023
@roanutil roanutil deleted the feature/improve-option-decodable-conformance branch May 9, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants