-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/improve option decodable conformance #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
roanutil
commented
May 5, 2023
- Add static functions of unwrap implementations on Option when unwrap is not required in the initializer
- Add convenience initializers when Value conforms to RawRepresentable and when Value conforms to both RawRepresentable and CustomStringConvertible
- Relax Option's conformance to Decodable to not require Value conform to CustomStringConvertible. Instead, throw error if unwrap implementation is not found in the Decoder's userInfo dictionary
- Add conditional conformance to DecodableWithConfiguration to Option
- Add test cases to OptionTests to catch regressions of behavior when Option.Value conforms to both RawRepresentable and CustomStringConvertible
- Add default.profraw to gitignore
- Add explicit token for codecov in macos-test workflow job
- Update dependencies
…is not required in the initializer feature/improve-option-decodable-conformance
…CustomStringConvertible> and when Value conforms to both RawRepresentable<CustomStringConvertible> and CustomStringConvertible feature/improve-option-decodable-conformance
…to CustomStringConvertible. Instead, throw error if unwrap implementation is not found in the Decoder's userInfo dictionary. feature/improve-option-decodable-conformance
feature/improve-option-decodable-conformance
…ption.Value conforms to both RawRepresentable<CustomStringConvertible> and CustomStringConvertible feature/improve-option-decodable-conformance
feature/improve-option-decodable-conformance
feature/improve-option-decodable-conformance
feature/improve-option-decodable-conformance
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 86.48% 82.10% -4.39%
==========================================
Files 16 16
Lines 873 961 +88
==========================================
+ Hits 755 789 +34
- Misses 118 172 +54
|
sam-mfb
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.