Merge pull request #640 from BigBotNetwork/greg-dev

Prevent error in getByID function
MGP6775 · Mar 28, 2021 · 6c8b697 · 6c8b697
2 parents 162efd0 + ca1dd18
commit 6c8b697
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>Hadder</groupId>
     <artifactId>Hadder</artifactId>
-    <version>2.0.0</version>
+    <version>2.0.1</version>
     <name>Hadder</name>
     <inceptionYear>2019</inceptionYear>
     <description>Hadder is a multi-purpose Discord bot.</description>

diff --git a/src/main/java/one/bbn/hadder/db/Mongo.java b/src/main/java/one/bbn/hadder/db/Mongo.java
@@ -43,7 +43,11 @@ public Object getByID(String collection_name, String where, String what, String
         BasicDBObject whereQuery = new BasicDBObject();
         whereQuery.put(where, what);
         FindIterable<Document> it = collection.find(whereQuery);
-        return it.cursor().next().get(column);
+        try {
+            return it.cursor().next().get(column);
+        } catch (NoSuchElementException ignore) {
+            return null;
+        }
     }
 
     public JSONObject getObjectByID(String collection, String id) {
@@ -133,8 +137,7 @@ public void push(MongoUser user) {
     }
 
     public boolean hasStarboardMessage(String message_id) {
-        this.getByID("stars", "id", message_id, "guild");
-        return true;
+        return this.getByID("stars", "id", message_id, "guild") != null;
     }
 
     public void insertStarboardMessage(String message_id, String guild_id, String starboard_message_id) {