Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the upcrossing analysis functions in MATLAB #151

Merged
merged 21 commits into from
Feb 4, 2025
Merged

Adds the upcrossing analysis functions in MATLAB #151

merged 21 commits into from
Feb 4, 2025

Conversation

MShabara
Copy link

This PR is related to the uncrossing analysis utilities:
1- The upcrossing functions were added.
2- The upcrossing_Test unit test is added.

@MShabara MShabara changed the title Adding the uncrossing analysis functions coded in MATLAB Adds the uncrossing analysis functions in MATLAB Dec 16, 2024
@simmsa
Copy link
Contributor

simmsa commented Dec 18, 2024

@MShabara, if this is ready to go can you please add @rpauly18 and myself as reviewers? If not can you convert this to a draft?

@MShabara MShabara assigned MShabara and unassigned MShabara Dec 18, 2024
@MShabara MShabara requested a review from rpauly18 December 18, 2024 17:16
@MShabara MShabara changed the title Adds the uncrossing analysis functions in MATLAB Adds the upcrossing analysis functions in MATLAB Jan 14, 2025
@simmsa simmsa self-requested a review January 14, 2025 16:14
simmsa
simmsa requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@simmsa simmsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MShabara, overall the implementation looks good and I don't see any technical errors. Could you please:

  1. Update the docstrings to follow this projects format
  2. Address the inline comments I've left about test file locations, unused code, and citations

mhkit/tests/upcrossing_Test.m Outdated Show resolved Hide resolved
mhkit/tests/waveform_signal.txt Outdated Show resolved Hide resolved
mhkit/utils/upcrossing/README.md Outdated Show resolved Hide resolved
mhkit/utils/upcrossing/uc_apply_.m Outdated Show resolved Hide resolved
mhkit/utils/upcrossing/uc_apply_.m Outdated Show resolved Hide resolved
@simmsa simmsa mentioned this pull request Feb 3, 2025
Open
simmsa
simmsa reviewed Feb 3, 2025
View reviewed changes
examples/adcp_example.mlx Outdated Show resolved Hide resolved
simmsa
simmsa reviewed Feb 3, 2025
View reviewed changes
examples/wave_example.mlx Outdated Show resolved Hide resolved
@simmsa
Copy link
Contributor

simmsa commented Feb 4, 2025

@MShabara, this looks good and all tests are passing. Thank you for your work on this! I am going to merge this into develop via a merge commit.

@simmsa simmsa merged commit c8cbd99 into MHKiT-Software:develop Feb 4, 2025
68 checks passed
@simmsa simmsa mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simmsa simmsa simmsa approved these changes

@rpauly18 rpauly18 Awaiting requested review from rpauly18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MShabara @simmsa