Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to plotting.surface_plotting and plotting.colormaps #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rcruces
Copy link

@rcruces rcruces commented Feb 2, 2023

  • added views to the default views of surface_plotting
  • added colormaps

@ReinderVosDeWael
Copy link
Collaborator

Love the change to add other views, although this would also need to be updated in the docstrings.

I'm not sure I see the value of these additional colormaps. What's the use-case for gradients? As gradients are continuous I'd see little use to adding discrete colormaps, and the good people over at matplotlib have already provided every colormap under the sun including an analysis of their pros/cons. I'd prefer to rely on those rather than risking the feature bloat / additional maintenance. If it's for ease of access within MICA tools wouldn't BrainStat be the more appropriate toolbox as its more of a swiss army-knife?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants