Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow REDIS Password and ZMQ Switch #56

Closed
wants to merge 1 commit into from
Closed

Allow REDIS Password and ZMQ Switch #56

wants to merge 1 commit into from

Conversation

christianmg99
Copy link
Contributor

This code change allows for 2 new optional env variables REDIS_PASSWORD and ZMQ_ENABLE.
Current deployments without these variables aren't affected.

@ostefano
Copy link
Collaborator

ostefano commented May 2, 2024 •
edited
Loading

Not sure whether redis password is correctly loaded from docker-compose. Anyway ZMQ and redis password are two different concerns, so it would make sense to split the PR.

@ostefano ostefano self-requested a review May 3, 2024 12:42
ostefano
ostefano requested changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@ostefano ostefano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should have the env vars documented inside template.env, and picked up and forwarded to the container in the docker-compose.yml file as well.

@ostefano
Copy link
Collaborator

ostefano commented May 3, 2024

LGTM, but we should have the env vars documented inside template.env, and picked up and forwarded to the container in the docker-compose.yml file as well.

Also misp-modules needs to pick up the password as well.

@ostefano
Copy link
Collaborator

ostefano commented Jun 1, 2024

This PR would solve #9

@ostefano ostefano linked an issue Jun 1, 2024 that may be closed by this pull request
Redis password? #9
Closed
@ostefano ostefano closed this Aug 12, 2024
@ostefano
Copy link
Collaborator

Broke as is, #107 supersedes it

@ostefano ostefano removed a link to an issue Aug 12, 2024
Redis password? #9
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostefano ostefano ostefano requested changes

Assignees

@christianmg99 christianmg99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianmg99 @ostefano