Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter apply_critical_fixes() to check that a setting has not already been set before forcing to safe default. #66

Merged
merged 11 commits into from
Jun 6, 2024

Commits on May 28, 2024

  1. Alter apply_critical_fixes() to test first. Required ugly kludge for …

    …Security.auth array which is not understood by MISP as part of the settings model.
    UFOSmuggler committed May 28, 2024
    Configuration menu
    Copy the full SHA
    46f05e9 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Make safe settings functions handling config json objects. They test …

    …settings aren't set before setting defaults. Currently env vars override safe settings. Also, create empty config.php instead of using template. Still need to validate all wanted settings are there. Also, update cake's cacerts. Previous method was using ubuntu's crts, which weren't pem.
    UFOSmuggler committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b6ba4fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea87025 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Move settings into files in /etc/misp-docker.

    Some files are pseudo-json as they include bash variables.
    
    Enforce all env var driven settings.
    
    Add gettext package for envsubst command, for filling in pseudo-json files with env vars.
    
    Move unset setting defaulting and enforcement of env var driven settings behind init_settings() function to dramatically improve code reuse.
    UFOSmuggler committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    ae8a00d View commit details
    Browse the repository at this point in the history
  2. fix Security.auth kludge

    UFOSmuggler committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    4217518 View commit details
    Browse the repository at this point in the history
  3. fix friday afternoon use of 'if ! thing != thing2' to just 'if thing …

    …== thing2'
    UFOSmuggler committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    7375b72 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Configuration menu
    Copy the full SHA
    111334d View commit details
    Browse the repository at this point in the history
  2. add documentation to readme.md

    UFOSmuggler committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1675d22 View commit details
    Browse the repository at this point in the history
  3. add a bit of context around adding new envars

    UFOSmuggler committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4d45c28 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Still a WIP

    Create CLI_only config directives first (in anticipation of enabling db settings), this involves moving some items around, including the workers directives surprisingly
    
    Await the arrival of the system_settings db table before processing whether or not to enable the DB.  This is not part of the default schema imported upon initialisation.  WIP - turn this into an until loop.
    
    Place the config template next to config.php as an example for the administrator.
    
    Add missing config directives, bring others in line with existing container config values.
    
    Fix some minor issues
    UFOSmuggler committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    ab57dbf View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Add ENABLE_DB_SETTINGS envar for turning on MISP.system_setting_db

    Add documentation regarding new envar, and add to docker-compose.yml and template.php
    
    Move "weird default" ZeroMQ setting to initialisation settings.
    
    Move some settings to cli_only, as by design or perhaps because the settings model and/or app controller just doesn't account for them being in the db, they have to be in the config.php file.
    
    Add code to disable DB settings when applying cli_only settings.
    
    Change system_settings table availability check to until loop.
    
    Some language changes for clarity.
    
    Should now be ready for testing.
    UFOSmuggler committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5b00a62 View commit details
    Browse the repository at this point in the history