This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
Use mutableCopy for many of the fields in copyForRetry. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields are declared as NSMutableArray / NSMutableDictionary, so it's violating the type safety to use plain copy. This is important if you try to cancel an operation that came from cancelForRetry. [MKNetworkOperation cancel] will clear all the lists of all the callbacks, which will crash if the lists are not mutable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields are declared as NSMutableArray / NSMutableDictionary,
so it's violating the type safety to use plain copy.
This is important if you try to cancel an operation that came from
cancelForRetry. [MKNetworkOperation cancel] will clear all the
lists of all the callbacks, which will crash if the lists are not
mutable.