Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opta data never converts to goalkick SPADL action #45

Closed
JeroenClijmans1 opened this issue Mar 17, 2021 · 1 comment
Closed

Opta data never converts to goalkick SPADL action #45

JeroenClijmans1 opened this issue Mar 17, 2021 · 1 comment

Comments

@JeroenClijmans1
Copy link

When converting Opta event stream data, there is never a conversion to a 'goalkick' SPADL action.

To do so, the _get_type_id function in opta.py needs to be changed. According to this source (couldn't find an up-to-date official document on the internet), a goal kick corresponds to pass qualifier 124.

Another question also arises: is a keeper throw (qualifier 123) also considered a goal kick in terms of SPADL actions. I think it makes sense to either have separate SPADL actions for these two, or one (renamed?) SPADL action for them both. I do not think that a keeper throw should be considered a regular pass, since there is no pressure on the keeper to execute this action quickly (in contrast to a regular pass). Therefore it may need a different treatment when processing the data.

@probberechts
Copy link
Member

Thanks! Good catch. The goalkicks should be fixed in e639437. I'll make the discussion about keeper throws part of #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants