Skip to content

Commit

Permalink
Form stacking context if display style is none
Browse files Browse the repository at this point in the history
Summary:
Changelog: [Internal]

View gets flattened even though it has `display: none` and therefore it and its children do not get hidden.

Reviewed By: shergin, mdvacca

Differential Revision: D21929033

fbshipit-source-id: 994a79fb64fbe66273a70218ebe8056d92cd3cd4
  • Loading branch information
sammy-SC authored and facebook-github-bot committed Jun 9, 2020
1 parent 3bf3f63 commit 1fa3a8e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ReactCommon/fabric/components/view/ViewShadowNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ void ViewShadowNode::initialize() noexcept {
viewProps.elevation != 0 ||
(viewProps.zIndex != 0 &&
viewProps.yogaStyle.positionType() == YGPositionTypeAbsolute) ||
viewProps.yogaStyle.display() == YGDisplayNone ||
viewProps.getClipsContentToBounds() ||
isColorMeaningful(viewProps.shadowColor);

Expand Down

0 comments on commit 1fa3a8e

Please sign in to comment.